Fix: Send folderKey on SignalR connect #123
Merged
+26
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where the folderKey was not being sent during SignalR connection establishment. The fix moves folder key initialization logic from the registration phase to earlier in the execution flow and ensures it's included in SignalR connection headers.
Key changes:
- Moved folder key retrieval logic from
_register()method to the mainexecute()method - Added folder_key to the SignalR client connection headers
- Updated context to include folder_key as a required field
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| cli_run.py | Added folder_key initialization from environment variable |
| _runtime.py | Moved folder key logic to execute() method and added to SignalR headers |
| _context.py | Added folder_key field to runtime context |
| pyproject.toml | Version bump to 0.0.97 |
cristipufu
force-pushed
the
fix/send_folder_key_signalr
branch
from
0de20d8 to
6bdd820
Compare
radu-mocanu
approved these changes
Jul 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an issue where the
folderKeywas not being sent during SignalR connection establishment. The fix moves folder key initialization logic from the registration phase to earlier in the execution flow and ensures it's included in SignalR connection headers._register()method to the mainexecute()methodfolder_keyto the SignalR client connection headers